lua-users home
lua-l archive

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]

Well it does not make sense for this patch really
as it fixes the build with older llvm-mingw toolchains,
it does not add any new features so does not seem to
fit well for Power Patches.

We just have this patch for the Lua build for VLC
and I thought I would share it with upstream Lua
maintainers as they could have been interested
in the fix.

On 25 Nov 2021, at 2:38, Jonathan Goble wrote:

As an addendum to this, if you have a patch to add features or change/improve behavior, there is a Power Patches page [1] on the wiki that you can contribute patches to. These aren't merged into any repo, but rather are available for power users to download to their system and then apply with one command before running "make". It's up to you to maintain the patch, i.e. make sure it continues to apply cleanly and work correctly with new releases of Lua, but it's an option if you want to make your code more widely available.

[1]: http://lua-users.org/wiki/LuaPowerPatches

On Wed, Nov 24, 2021 at 8:33 PM Jonathan Goble <jcgoble3@gmail.com> wrote:
On Wed, Nov 24, 2021 at 7:58 PM Marvin Scholz <epirat07@gmail.com> wrote:

Oh wow thats disappointing. Thanks for letting me know though!

It would be great if that was stated in a more obvious place
like on the Github Mirror (which directs to this mailing list)

The GitHub mirror is an *exact* copy of the Lua team's internal repo. (Note that the GitHub repos reflect the file structure as it is developed, not as it is arranged in the official tarballs, and also contain the internal Makefiles rather than the release Makefiles.) To add a note to it would require the Lua team to make that commit internally, although that might not be a bad idea.

and maybe make a note about this on the Community [1] page…

Possibly, though I think the FAQ note is sufficient. The Community page IMO should avoid negative statements and focus on positive statements.

I have no idea how you even found that FAQ page, I can not find
it linked anywhere.

The FAQ page is linked from the header strip on the main documentation page: https://www.lua.org/docs.html (this is the page you get from clicking Documentation on the home page).