Re: Lua 5.4.0-rc5 segfault in low memory conditions

[Sergey Zakharchenko <doublef.mobile@...>]

Andrew,

Sergey Zakharchenko <doublef.mobile@gmail.com>:
> Andrew Gierth <andrew@tao11.riddles.org.uk>:
> > See if this fixes both of them:
> > --- src/lparser.c.orig  2020-06-13 19:57:47.428734000 +0100
> > +++ src/lparser.c       2020-06-13 19:58:08.039573000 +0100
>
> Thanks for your awesome analysis! I'll start testing this now, but
> please note one thing I hadn't mentioned before: the original issue
> discovered on MIPS was actually discovered when loading bytecode, with
> no parser involved. It's possible we aren't done with this yet...

Huh, similar code in lundump.c has no barriers as well... Does it make
sense to add them?

    f->p[i] = luaF_newproto(S->L);
   /* here */
    loadFunction(S, f->p[i], f->source);

  cl->p = luaF_newproto(L);
   /* here */
 loadFunction(&S, cl->p, NULL);

Best regards,

-- 
DoubleF