lua-users home
lua-l archive

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]


First, I would like polite and constructive criticism for the rejected cases.
  They were given to you in the previous thread.

Second, more importantly, that the name and email of any and all who contribute to Lua be published in the commit. 
 
1.9 – Do you accept patches?
We encourage discussions based on tested code solutions for problems and enhancements, but we never incorporate third-party code verbatim. We always try to understand the issue and the proposed solution and then, if we choose to address the issue, we provide our own code. All code in Lua is written by us. See also the previous question. 
From: https://www.lua.org/faq.html#1.9 

On Thu, Dec 10, 2020 at 10:26 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
Em qui., 10 de dez. de 2020 às 11:52, Spar <developspartv@gmail.com> escreveu:
 Isn't this better if you tell what patches you made?
I think this question deserves a better answer.
Of course, I can publish the patch (currently 43k).
However, I have two conditions.
First, I would like polite and constructive criticism for the rejected cases.
Second, more importantly, that the name and email of any and all who contribute to Lua be published in the commit.
Is it too much to ask?

I'm applying my optimization knowledge in a great and interesting case (Lua) and
I believe that the patch has a good things and a lot of nonsense.
Third objective, learn in the process.
And I publicly acknowledge that the strncmp case was not a great idea.

regards,
Ranier Vilela