Re: PL/Lua updated for Lua 5.3, needs testing

[Bertrand Mansion <lua@...>]

> Le 20 mars 2016 à 13:23, Marc Balmer <marc@msys.ch> a écrit :
> 
> Bertrand,
> 
>> I recommend that you use the "Merge request" feature of Github before merging your changes. This way, we can review your changes before they are merged into the master branch, it's easier this way.
> 
> Sure, no problem.  So I fork on github and use the fork as my new origin, and after pushing I can to a pull request on github, right? (I was working from the command line, not via guthub).

Exactly, you fork the repo, then you modify your own fork and when it's good, you make a Pull request.

> Sure.  For now I only made sure it builds (and somehow runs) with Lua 5.3.  More tests to come.
> 
> btw, I suggest to remove the pllua.sql file since that is generated from pllua.sql.in when the module is built. And it gets in your way in case you compile pllua in a different location (setting VPATH to the sources). See the attached GNUmakefile, it fails to build/install pllua when the source dir contains this pllua.sql file.  What do you think about removing pllua.sql?

That's fine with me if it is supposed to be a generated file.

We can use the Github issues feature to continue our discussion if you want.
FYI, another contributor just added Luajit support to the trusted version of Pl/lua (was only working with untrusted before).

--
Bertrand