lua-users home
lua-l archive

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]

Am 19.11.2015 um 02:01 schröbte Daurnimator:
On 19 November 2015 at 11:28, Luiz Henrique de Figueiredo
<> wrote:
The diffs are also available in unified format:

When creating unified diffs for C code, consider passing '-p' so that
it (additionally) emits which C function each diff chunk relates to.
Makes it easier to browse :)

All feedback welcome. Thanks.

Interesting to see that in functions such as lua_rawseti, `hvalue` is
now called twice.
Was this fixing any particular issue?

The caching in upvalues for type() is a nice touch

Actually the upvalue trick is reverted in this release (presumably because the string caching is good enough?).

Typo in comment of moveresults. ('ajdust')

Why does ltablib.c now `#include <time.h>`

Because `clock()` and `time()` are used to find a pivot element for sorting.

Btw., the manual now says:

> Note that the <code>comp</code> function must define
> a strict partial order over the elements in the list;
> that is, it must be asymmetric and transitive.
> Otherwise, no valid sort may be possible.

Shouldn't that be a (strict) *total* order (i.e. all elements may be compared to each other)?

Also there are a lot of superfluous `sizeof(char)`s in the code.