lua-users home
lua-l archive

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]


Thanks for your feedback.

The addString stuff was something I got from the Lua site or the LuaUsers wiki, can't remember, on the subject of repetetive string concatenation.
Maybe it'd be easier to just replace those with the actual commands.

And sure, I'll go make some prettier names now.

On 17 April 2010 10:18, Quae Quack <quae@daurnimator.com> wrote:
There are many things you still need to do before you can really say
you're serialising functions (first you'll need to look at upvalues,
also you'll need to bail out if the function is a C function.)
Also I think you'll have problems with cyclical tables; in general
you're not handling duplicate objects at all....
Also performance of your table serialisation leaves much to be
desired: I'm not sure what your addString function is trying to
achieve; but simply adding everything to a table then using
table.concat beats everything else by far.

Also also, I commend you for your localisation of standard library
functions, but pick some easier to read names next time!
(additionally, get to know the # operator)