[Date Prev][Date Next][Thread Prev][Thread Next]
[Date Index]
[Thread Index]
- Subject: Re: Assertion failure in 5.1 work5
- From: Mark Hamburg <mhamburg@...>
- Date: Tue, 26 Apr 2005 08:41:15 -0700
I haven't heard any further reports on our side either since rolling in the
patch, but it's been less than 24 hours and I wasn't the one who was hitting
it most often. Keeping my fingers crossed.
Mark
on 4/26/05 2:20 AM, Adam D. Moss at adam@gimp.org wrote:
> Roberto Ierusalimschy wrote:
>> To test this theory, those with the bug could just remove the following
>> lines from luaF_close (lfunc.c:108):
>>
>> unlinkupval(uv);
>> setobj(L, &uv->u.value, uv->v);
>> - if (isgray(o)) {
>> - gray2black(o); /* closed upvalues are never gray */
>> - luaC_barrier(L, uv, &uv->u.value);
>> - }
>> uv->v = &uv->u.value; /* now current value lives here */
>> luaC_linkupval(L, uv); /* link upvalue into `gcroot' list */
>
> With this patch, it seems that I can no longer reproduce the
> previously fairly reproducable problem.
>
> Thanks!
>
> --Adam