[Date Prev][Date Next][Thread Prev][Thread Next]
- Subject: RE: PATCH: Add Type Checking in op_bitwiseK
- From: Tatsuhiro Aoshima <tatsuhiro.aoshima.md@...>
- Date: Thu, 22 Apr 2021 14:12:25 +0900
Thank you for your reply.
> As the comments in 'lopcodes.h' indicate, the compiler ensures that these constants are always integers. (Your patch assumes they
are always numbers).
Of course, I know.
Already, op_arithK checks both operands because it calls op_arith_aux.
Hence, I proposed op_bitwiseK should check also.
I wonder how the developers think this inconsistent and unclear implementation.
I think some attacks in the future may use this code in order to leak some pointers as integers,
as exploiting another bugs.
。:+* ゜ ゜゜ *+:。:+* ゜ ゜゜ *+:。:+* ゜ ゜゜ *+:。
NTT Secure Platform Laboratories
Phone: +81 422 59 3261 [JPN: (0422) 59 3261]