Re: luaX_token2str() error: buffer overflow 'luai_ctype_'

[Toomas Soome <tsoome@...>]

On 9. Sep 2020, at 15:22, Luiz Henrique de Figueiredo <lhf@tecgraf.puc-rio.br> wrote:

So, as the assumption is that 256 is impossible value, we can set up assert or condition to test that value.

The code already has this:
    lua_assert(token == cast(unsigned char, token));

yep. it does. Also it has 

#define lua_assert(c)         ((void)0)

Which does explain the issue about smatch not seeing the check, and of course, it also means, unless the data segment layout is not favoring us, no-one will ever know if the bug did hit or not:)

thanks,

toomas