Re: [ANN] Lua 5.3.3 (rc1) now available

[François Perrad <francois.perrad@...>]

2016-05-05 2:30 GMT+02:00 Luiz Henrique de Figueiredo <lhf@tecgraf.puc-rio.br>:
> Lua 5.3.3 (rc1) is now available for testing at
>         http://www.lua.org/work/
>
> Lua 5.3.3 fixes all bugs listed in
>         http://www.lua.org/bugs.html#5.3.2
>
> Lua 5.3.3 also contains several internal improvements and includes a
> revised reference manual:
>         http://www.lua.org/work/doc/
>
> Like all minor releases, this is a bug-fix release; no new features have
> been added.
>
> The tarball is at
>         http://www.lua.org/work/lua-5.3.3-rc1.tar.gz
>
> The checksums are
>         MD5     facc49a32fed3ec14291677eb95abc1b  -
>         SHA1    0b4ad25b4623541b2a60cec96bf880d28e63e156  -
>
> The complete diffs from Lua 5.3.2 to rc1 are available at
>         http://www.lua.org/work/diffs-lua-5.3.2-lua-5.3.3-rc1.txt
>         http://www.lua.org/work/diffs-lua-5.3.2-lua-5.3.3-rc1.html
>
> The diffs are also available in unified format:
>         http://www.lua.org/work/diffu-lua-5.3.2-lua-5.3.3-rc1.txt
>         http://www.lua.org/work/diffu-lua-5.3.2-lua-5.3.3-rc1.html
>
> A test suite for Lua 5.3.3 is available at
>         http://www.lua.org/work/lua-5.3.3-tests.tar.gz
>
> We thank everyone for their feedback on Lua 5.3 till now.
>
> All feedback welcome. Thanks.

By linting, I found 2 minor problems (see fix in attached patch) with the
FALLTROUGH comment.

François

> --lhf
>
>

From 6645c18e1a91d83cc7a9cb11d01f032065f40f02 Mon Sep 17 00:00:00 2001
From: Francois Perrad <francois.perrad@gadz.org>
Date: Tue, 3 May 2016 21:25:21 +0200
Subject: [PATCH] comment FALLTHROUGH

---
 src/lcode.c   | 2 +-
 src/lstrlib.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lcode.c b/src/lcode.c
index 1027aa1..c48a483 100644
--- a/src/lcode.c
+++ b/src/lcode.c
@@ -1065,7 +1065,7 @@ void luaK_prefix (FuncState *fs, UnOpr op, expdesc *e, int line) {
     case OPR_MINUS: case OPR_BNOT:
       if (constfolding(fs, op + LUA_OPUNM, e, &ef))
         break;
-      /* else go through */
+      /* else go through *//* FALLTHROUGH */
     case OPR_LEN:
       codeunexpval(fs, cast(OpCode, op + OP_UNM), e, line);
       break;
diff --git a/src/lstrlib.c b/src/lstrlib.c
index a610a0d..6a973f0 100644
--- a/src/lstrlib.c
+++ b/src/lstrlib.c
@@ -958,8 +958,8 @@ static void addliteral (lua_State *L, luaL_Buffer *b, int arg) {
         addliteralnum(L, b, lua_tonumber(L, arg));
         break;
       }
-      /* else integers; write in "native" format *//* FALLTHROUGH */
-    }
+      /* else integers; write in "native" format */
+    } /* FALLTHROUGH */
     case LUA_TNIL: case LUA_TBOOLEAN: {
       luaL_tolstring(L, arg, NULL);
       luaL_addvalue(b);
-- 
2.7.4