lua-users home
lua-l archive

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]


Just some minor feedback.

For the define, LUA_32BITS the use of LUA_INT_LONG struct me as
strange, and I think LUA_INT_INT might be better.

When compiling for 64-bit, under LP64 systems (e.g. Mac, Linux), long
will be 64-bit. And particularly in the case of OS X, iOS, and Android
where you ship multiple architectures (both 32-bit and 64-bit in the
same blob), this means the size of lua_Integer will vary between your
32-bit and 64-bit slices (which is not necessarily a bad thing, but I
claim it is unexpected by using a flag named LUA_32BITS).

My thinking/expectation is that by using LUA_32BITS, I will get 32-bit
even on 64-bit builds.

Thus, I think LUA_INT_INT would be better, unless there are platforms
in mainstream use where int resolves to 16-bits.

Thanks,
Eric
--
Beginning iPhone Games Development
http://playcontrol.net/iphonegamebook/