lua-users home
lua-l archive

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]


Steven Johnson wrote:
> The code is a bit horrible-looking at the moment. :D It shows most
> things I tried, sans vector types and maybe one or two more things.

Well, storing and reloading from FFI types only to force a
truncation is almost never a win.

I've cleaned up the 2D case and improved it a bit. It's about 50%
faster now. See the attached file.

> Also, Mike: If I call SignBit() in Simplex3D (commented out in the
> code) instead of inlining its body, I get rather different results:
> something like (-168, 168) for the minimum and maximum. Am I
> overlooking anything here? This is raw beta 6, no patches.

Umm, this doesn't make sense:
  if jit.status("be") then ...
You probably meant ffi.abi("be")?

Also, type punning through a union violates the strict aliasing
rules. Depends a lot on the surrounding context whether it does
what you intended it to do (usually it doesn't).

As you can see from the code, there's a simpler (and portable) way
to do it: local a = rshift(floor(y0 - x0), 31)

--Mike
local ffi = require("ffi")
local bit = require("bit")

local floor, max = math.floor, math.max
local band, rshift = bit.band, bit.rshift

local Perms = ffi.new("uint8_t[512]", {
  151, 160, 137, 91, 90, 15, 131, 13, 201, 95, 96, 53, 194, 233, 7, 225,
  140, 36, 103, 30, 69, 142, 8, 99, 37, 240, 21, 10, 23, 190, 6, 148,
  247, 120, 234, 75, 0, 26, 197, 62, 94, 252, 219, 203, 117, 35, 11, 32,
  57, 177, 33, 88, 237, 149, 56, 87, 174, 20, 125, 136, 171, 168, 68, 175,
  74, 165, 71, 134, 139, 48, 27, 166, 77, 146, 158, 231, 83, 111, 229, 122,
  60, 211, 133, 230, 220, 105, 92, 41, 55, 46, 245, 40, 244, 102, 143, 54,
  65, 25, 63, 161, 1, 216, 80, 73, 209, 76, 132, 187, 208, 89, 18, 169,
  200, 196, 135, 130, 116, 188, 159, 86, 164, 100, 109, 198, 173, 186, 3, 64,
  52, 217, 226, 250, 124, 123, 5, 202, 38, 147, 118, 126, 255, 82, 85, 212,
  207, 206, 59, 227, 47, 16, 58, 17, 182, 189, 28, 42, 223, 183, 170, 213,
  119, 248, 152, 2, 44, 154, 163, 70, 221, 153, 101, 155, 167, 43, 172, 9,
  129, 22, 39, 253, 19, 98, 108, 110, 79, 113, 224, 232, 178, 185, 112, 104,
  218, 246, 97, 228, 251, 34, 242, 193, 238, 210, 144, 12, 191, 179, 162, 241,
  81, 51, 145, 235, 249, 14, 239, 107, 49, 192, 214, 31, 181, 199, 106, 157,
  184, 84, 204, 176, 115, 121, 50, 45, 127, 4, 150, 254, 138, 236, 205, 93,
  222, 114, 67, 29, 24, 72, 243, 141, 128, 195, 78, 66, 215, 61, 156, 180
})
ffi.copy(Perms + 256, Perms, 256)

local Perms12 = ffi.new("uint8_t[512]")
for i=0,255 do local x = Perms[i] % 12; Perms12[i] = x; Perms12[i+256] = x; end

local Grads2 = ffi.new("const double[12][4]",
  {1,1,0},{-1,1,0},{1,-1,0},{-1,-1,0},
  {1,0,1},{-1,0,1},{1,0,-1},{-1,0,-1},
  {0,1,1},{0,-1,1},{0,1,-1},{0,-1,-1})

do
  local function GetN(ix, iy, x, y)
    local t = .5 - x * x - y * y
    local index = Perms12[ix + Perms[iy]]
    return max(0, (t*t) * (t*t)) * (Grads2[index][0] * x + Grads2[index][1] * y)
  end

  function Simplex2D(x, y)
    local s = (x + y) * 0.366025403
    local ix, iy = floor(x + s), floor(y + s)
    local t = (ix + iy) * 0.211324865
    local x0 = x + t - ix 
    local y0 = y + t - iy
    ix, iy = band(ix, 255), band(iy, 255)
    local n0 = GetN(ix, iy, x0, y0)
    local n2 = GetN(ix+1, iy+1, x0 - 0.577350270, y0 - 0.577350270)
    local a = rshift(floor(y0 - x0), 31)
    local n1 = GetN(ix+a, iy+(1-a), x0+0.211324865-a, y0-0.788675135+a)
    return 70 * (n0 + n1 + n2)
  end
end

-- test code
local S = Simplex2D
local mmin, mmax = math.min, math.max
local fmin, fmax = 10000, -10000
local t1 = os.clock()
for i=1,5000 do
  for j=1,5000 do
    local f = S(i + .5, j + .3)
    fmin = mmin(fmin, f)
    fmax = mmax(fmax, f)
  end
end
print(string.format("Simplex2D: time / call = %.9f, min = %f, max = %f",
      (os.clock() - t1) / (5000 * 5000), fmin, fmax))