Re: Add pclose, 'fix' GC of files closed where fclose fails

[David Given <dg@...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Panetta wrote:
[...]
> Please look at this patch and tell me if I have made any grave errors, as
> this is my first attempt at patching one of the core libraries of LUA, and
> the intent is to add functionality and not change it (if possible).

You should be aware that it's not strictly legal to call fclose() on a
FILE* that was previously opened with popen(), or pclose() on one that
was opened with fopen(). It happens to work on a lot of platforms, but
only by chance.

- --
+- David Given --McQ-+ "Preacher, don't the Bible have some pretty
|  dg@cowlark.com    | specific things to say about killing?" "Quite
| (dg@tao-group.com) | specific. It is, however, somewhat fuzzier on the
+- www.cowlark.com --+ subject of kneecaps." --- Firefly, _War Stories_
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEV3Ilf9E0noFvlzgRAhrRAKCcpSrg6kIx2tXbQvs/9kDvuaMvjQCfZaxA
CEGWNzG/2Muf4Nb6zTBzpak=
=yYO+
-----END PGP SIGNATURE-----